Merged
Conversation
deprecated poetry, linters and formatters removed all unused configuration files. Signed-off-by: tsanchez <v-tsanchez@acvauctions.com>
switch to Python 3.11, improve caching, and refine Makefile targets Signed-off-by: tsanchez <v-tsanchez@acvauctions.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request transitions the project from poetry to uv for dependency management, updates the Python version to 3.11.4, refactors the Docker configuration, and cleans up various tool configurations.
- Dependency management updated from poetry to uv
- Python version upgraded and related configurations adjusted
- Dockerfile and CI/CD workflows refactored to align with the new dependency manager
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/template/version.py | Updated the application version from "0.0.1" to "1.0.0". |
| pyproject.toml | Replaced poetry configuration with a [project] section and updated dependencies; added configuration for ruff linting via [tool.ruff]. |
| mypy.ini, .isort.cfg, .flake8 | Removed obsolete files in favor of using ruff and hatchling. |
| docker-compose.yaml | Added a new Docker Compose file for local development with live-reloading. |
| README.md | Updated instructions to reflect the change from poetry to uv. |
| Makefile | Replaced poetry commands with uv equivalents and added new targets. |
| Dockerfile | Refactored to install uv, leverage build caching, and build a self-contained virtual environment. |
| .python-version, .pre-commit-config.yaml, .github/workflows/build.yml | Updated and aligned configuration files with the new dependency management and Python version. |
Comments suppressed due to low confidence (1)
Dockerfile:8
- The environment variable 'PYTHOPNUNBUFFERED' appears to be misspelled; consider using 'PYTHONUNBUFFERED' to properly enable unbuffered output.
PYTHOPNUNBUFFERED=1 \
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: tsanchez <v-tsanchez@acvauctions.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant changes to the project, transitioning from
poetrytouvfor dependency management, updating the Python version to 3.11, and replacing several tools for linting, formatting, and testing. It also includes updates to the Docker configuration and project metadata. Below is a summary of the most important changes grouped by theme.Dependency Management and Tooling Updates:
poetrywithuvfor dependency management, reflected in theMakefile,README.md, andDockerfile. Commands likepoetry installandpoetry runare replaced withuv syncanduv runrespectively. [1] [2] [3].pre-commit-config.yamlfile to usepre-commit-hooksandruff-pre-commitinstead of custom hooks for tools likepylint,mypy,flake8, andisort.flake8,isort, andmypy(.flake8,.isort.cfg,mypy.ini) and replaced their functionality withruffinpyproject.toml. [1] [2] [3] [4]Python and Dependency Updates:
.python-version,Dockerfile, and CI workflows in.github/workflows/build.yml. [1] [2] [3]pyproject.tomlto use newer versions and restructured the file for compatibility withhatchling.Docker and Deployment Enhancements:
Dockerfileto useuvfor building and managing dependencies, replacingpoetry. Added caching and improved dependency installation.docker-compose.yamlfile to simplify local development with Docker, including live-reloading support.Codebase and Metadata Updates:
1.0.0inpyproject.tomlandsrc/template/version.py. [1] [2]README.mdto reflect the transition touvand removed outdated instructions forpoetry. [1] [2]Build and CI Improvements:
Makefileby replacingpoetrycommands withuvequivalents and adding new targets likeinstall,dev,format, andfix..github/workflows/build.ymlto useuvand Python 3.11.