Add Dual Pane Support and Single Token Scripts #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 Great Job |
matheuschimelli
approved these changes
Apr 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dual Pane view is a popular diff format. This change adds support for dual pane view via the diff function diff_dual_pane.
A dual pane diff returns two key-pairs. The 'before' key's value is the before input with deletions. The 'after' key's value is the after input with insertions.
Sample usage:
diff = require('./htmldiff.js');
console.log(diff.diff_dual_pane('input text', 'input texts'));
Single Token Scripts
The parser is entering into script tags. Javascript in these tags is getting mangled by the inclusion of html span tags to highlight differences. This change makes scripts single tokens for the purposes of diffing.