fixes #399 TypeError when parsing login response, fixes #397 throw when cert is null #565
+262
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: throw when cert is null tngan#397 Co-authored-by: rassul-findmypast <[email protected]> Co-authored-by: JAParsons <[email protected]> Co-authored-by: Jonathan Darrer <[email protected]> Co-authored-by: Matt Krick <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There has been an issue in the library that means it cannot handle multiple anonymous certificates for signing/encrypting.
The implementation to resolve this was to add an exclude attribute which will allow the extractor to get keys which do not include specified attributes.
Also this handling of not finding certificates would not provide a suitable error (fix provided from another PR (still awaiting acceptance))
fixes #399 TypeError when parsing login response, fixes #397 throw when cert is null.