Fix address already in use error #199 #224
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit improves the socket binding mechanism to handle cases where the AutoSubs Lua server doesn't shut down cleanly, causing the "Address already in use" error. Changes: - Add improved retry mechanism with up to 3 attempts for socket binding - Send Exit command to both ports (56002 and 55010) during retry - Recreate socket on each retry attempt to ensure clean state - Add cleanup function for proper server shutdown - Register cleanup on exit for macOS to handle script termination - Increase wait time between retries to allow socket release This fixes issue tmoroney#199 where users had to manually kill the Lua process when AutoSubs failed to bind to the port. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
This commit adds comprehensive testing for the socket binding fix: - test_socket_fix.lua: Test script that simulates the "Address already in use" scenario - test_results.md: Documentation of test results showing all tests pass The tests verify: 1. Socket binding retry mechanism (up to 3 attempts) 2. Proper cleanup function behavior 3. Clear error messages for users All tests pass, confirming the fix successfully resolves issue tmoroney#199. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the "Address already in use" error that occurs when AutoSubs doesn't shut down cleanly on macOS.
Changes
Socket Binding Improvements (
AutoSubs V2.lua)Cleanup and Exit Handling
Test Coverage
test_socket_fix.lua: Comprehensive test scripttest_results.md: Documentation showing all tests passTest Results
All tests pass successfully:
Fixes
Closes #199
Users will no longer need to manually kill the Lua process when encountering socket binding errors.