Cuda 12 and related patches #80
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmcdonell
approved these changes
May 29, 2025
There was a problem hiding this comment.
I did not read this extensively but I trust your judgement. You might consider (maybe as a separate PR) to just drop the entire runtime module: it has not been updated nor tested in ages, and does not fit in well with how to use CUDA from Haskell, so it's mostly just a headache to keep around at this point. It should really be its own package.
(some other libraries, e.g. cublas, technically assume/require the runtime interface, but they are easy to make work with the driver interface anyway)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are a bunch of changes that should make
cudaready for a new release, in my view. What do you think? Any critique welcome. (As I said before, a release of 0.12.8.0 does not preclude a release of 0.12.8.1 soon after.)I ended up reverting some of the DeviceResources values that I said before I'd keep, mainly because in the commit that introduced the differing values, the chip name still had a
(?)after it. :PCloses #74.
Closes #75.
Fixes #73.
Fixes #77.