Set up library configuration with setup.py and minor changes to source #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Description
This pull request introduces the possibility of installing the repo as a library, and it updates the code for compatibility purposes. Main motivation is to allow the usability of the code also with updated dependecies.
Change Description
Added a setup.py file and refactored the project structure to be installable with pip install .
Removed dependencies versions because of compatibility issues. Only nlopt must be pinned to be compatible with the code.
Added parameter "annotate" in plot method to choose the percentage of points to annotate (float from 0 to 1). Default changes to None (do not annotate).
If failing to find to an initial decision boundary (i.e. the model is confident about its predictions so that there are no points in a neighborood of 0.5) auto-increasing the acceptance threshold (range around 0.5 to consider the decision boundary points) with a step of 0.03. Fixed bug: keep trying to find the boundary in endless while loop.
Testing
Local Testing: I tested the library and the functionalities on my local linux machine and it worked as expected.