Skip to content

Simplify S3 storage config form#322

Merged
jamesacklin merged 2 commits intodevelopfrom
jamesacklin/simplify-s3-form
Mar 20, 2026
Merged

Simplify S3 storage config form#322
jamesacklin merged 2 commits intodevelopfrom
jamesacklin/simplify-s3-form

Conversation

@jamesacklin
Copy link
Member

Summary

  • Replaced react-hook-form with plain controlled useState inputs in the S3 storage preferences form
  • Fixed fields not accepting edits due to stale defaultValue captured before data loaded, broken isDirty detection, and type="url" rejecting valid endpoints
  • Removed all client-side required/validation gating on the submit button — the form now simply saves whatever values are present
  • Pokes are now awaited sequentially instead of fire-and-forget

Test plan

  • Open System Preferences > Remote Storage
  • Verify all fields populate with existing S3 config values
  • Edit each field and confirm typing works without issues
  • Click Save and confirm credentials persist after page reload
  • Toggle between Tlon hosting and custom S3 (on hosted ships) and verify the toggle still works

🤖 Generated with Claude Code

Replace react-hook-form with plain controlled inputs. The previous
implementation had stale defaultValues, broken isDirty detection, and
overly aggressive validation that prevented fields from being updated.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@jamesacklin jamesacklin requested a review from arthyn March 20, 2026 16:11
Copy link
Member

@arthyn arthyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit, lgtm though

</div>
<div className="mb-8 flex flex-col space-y-2">
<label className="font-semibold" htmlFor="publicUrlBase">
Public URL base (normally unnecessary)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd leave this parenthetical in

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@jamesacklin jamesacklin merged commit 55b9f01 into develop Mar 20, 2026
1 check passed
@jamesacklin jamesacklin deleted the jamesacklin/simplify-s3-form branch March 20, 2026 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants