*: fix curly brace syntax, nested placeholders and mismatched brackets #17210
+25
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
mass changes
Managor
commented
Jul 12, 2025
Managor
changed the title
Managor
commented
Jul 12, 2025
Managor
commented
Jul 12, 2025
Managor
changed the title
|
Oddly I came to doing this completely independent of #17198 |
Managor
changed the title
Managor
changed the title
acuteenvy
reviewed
Jul 12, 2025
Co-authored-by: Lena <[email protected]>
Co-authored-by: Lena <[email protected]>
acuteenvy
approved these changes
Jul 14, 2025
KristopherLeads
approved these changes
Jul 15, 2025
|
@Managor do you think there are any more upcoming edits, or are we ready to commit? |
|
@KristopherLeads Nothing that comes to mind. I'll let you do the honors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were found by running
grep -r {{{andgrep -r }}}in the project#17107
Even more found with
find . -type f -print0 | xargs -0 awk '{ o=gsub(/{/,"&"); c=gsub(/}/,"&"); if(o!=c) print FILENAME ": " $0 }'find . -type f -print0 | xargs -0 awk '{ o=gsub(/\[/,"&"); c=gsub(/\]/,"&"); if(o!=c) print FILENAME ": " $0 }'find . -type f -print0 | xargs -0 awk '{ o=gsub(/\(/,"&"); c=gsub(/\)/,"&"); if(o!=c) print FILENAME ": " $0 }'find . -type f -print0 | xargs -0 awk '{ q=gsub(/"/,"&"); if(q % 2 != 0) print FILENAME ": " $0 }'Also found an interesting case where a
<was not inside" "with thisfind . -type f -print0 | xargs -0 awk '{ o=gsub(/</,"&"); c=gsub(/>/,"&"); if(o!=c) print FILENAME ": " $0 }' | cut -d : -f 2- | grep -v '\.' | grep "[a-zA-Z]<"