-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
kdash: add page #17154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kdash: add page #17154
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for your contribution
Consider submitting the translation after the english page has been merged so that we don't have to wait for translation maintainers to approve and so that fixes don't have to be applied multiple times. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also apply these changes to the Japanese translation.
Co-authored-by: Wiktor Perskawiec <[email protected]>
Thank you for your review. |
Can you address the issues highlighted in this PR? |
Sorry for replying late. I'll handle these issues ASAP. |
Co-authored-by: Dylan <[email protected]>
Co-authored-by: Dylan <[email protected]>
Co-authored-by: Wiktor Perskawiec <[email protected]>
Co-authored-by: Managor <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
Hello! I've noticed something unusual when checking this PR:
Is this intended? If so, just ignore this comment. Otherwise, please double-check the commits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to go after the last suggestion is implemented.
I'll just push these simple changes and merge. |
Co-authored-by: Lena <[email protected]>
common
,linux
,osx
,windows
,sunos
,android
, etc.