Skip to content

Conversation

Akasan
Copy link
Contributor

@Akasan Akasan commented Jul 7, 2025

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The page(s) follow the style guide.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

@github-actions github-actions bot added new command Issues requesting creation of a new page or PRs adding a new page for a command. new translation PRs translating a page(s) from English to other languages. review needed Prioritized PRs marked for reviews from maintainers. labels Jul 7, 2025
Copy link
Member

@spageektti spageektti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for your contribution

@Managor
Copy link
Member

Managor commented Jul 7, 2025

Consider submitting the translation after the english page has been merged so that we don't have to wait for translation maintainers to approve and so that fixes don't have to be applied multiple times.

Copy link
Member

@dmmqz dmmqz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also apply these changes to the Japanese translation.

Co-authored-by: Wiktor Perskawiec <[email protected]>
@Akasan
Copy link
Contributor Author

Akasan commented Jul 8, 2025

Consider submitting the translation after the english page has been merged so that we don't have to wait for translation maintainers to approve and so that fixes don't have to be applied multiple times.

Thank you for your review.
That's true. It would be better to create the page in English first, and then translate it, which would reduce the number of changes. Thank you.

@Managor
Copy link
Member

Managor commented Jul 15, 2025

Can you address the issues highlighted in this PR?

@spageektti
Copy link
Member

@Akasan

@Akasan
Copy link
Contributor Author

Akasan commented Jul 16, 2025

Can you address the issues highlighted in this PR?

Sorry for replying late. I'll handle these issues ASAP.

@Akasan Akasan requested review from spageektti, Managor and dmmqz July 18, 2025 15:21
@Akasan Akasan requested review from Managor and dmmqz July 19, 2025 05:23
@tldr-bot

This comment was marked as outdated.

@tldr-bot
Copy link

Hello! I've noticed something unusual when checking this PR:

Is this intended? If so, just ignore this comment. Otherwise, please double-check the commits.

Copy link
Member

@Managor Managor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go after the last suggestion is implemented.

@Managor
Copy link
Member

Managor commented Jul 20, 2025

I'll just push these simple changes and merge.

@Managor Managor merged commit 18e7e69 into tldr-pages:main Jul 20, 2025
4 checks passed
@Akasan Akasan deleted the add-kdash branch July 21, 2025 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command. new translation PRs translating a page(s) from English to other languages. review needed Prioritized PRs marked for reviews from maintainers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants