Handling redis connection problems in cache implementation#3
Open
megamattron wants to merge 1 commit intotkral:masterfrom
Open
Handling redis connection problems in cache implementation#3megamattron wants to merge 1 commit intotkral:masterfrom
megamattron wants to merge 1 commit intotkral:masterfrom
Conversation
…tation can handle it appropriately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there, I'm not sure how many people use this plugin anymore but in case it's useful we've made some changes to the caching implementation that might be generally useful.
In general, in a caching situation when failing to connect to redis we just want to have the cache not return a value, or fail to set a cached value. We don't want it to throw an exception and cause a 500 error. So this set of changes reports connection problems but generally suppresses them. Any suggestions or feedback appreciated!