Skip to content

bugfix: incorrect raw byte conversion to string #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
IdrisHanafi wants to merge 3 commits into
base: main
Choose a base branch
from
Open

bugfix: incorrect raw byte conversion to string #72

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ad0a7df
bugfix: incorrect raw byte conversion to string
IdrisHanafi Mar 5, 2025
2d898c1
feat: adding flag for decrypted output types
IdrisHanafi Mar 6, 2025
f2af6b6
Merge branch 'main' into bugfix/incorrect-raw-byte-conversion-to-string
IdrisHanafi Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/cmd/turnkey/pkg/decrypt.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ var (
// EncryptionKeypair is the loaded Encryption Keypair.
EncryptionKeypair *encryptionkey.Key

// Controls whether output is UTF-8 string or hex string
hexOutput bool

// Solana address, required for exporting Solana private keys in the proper format
solanaAddress string
)
Expand All @@ -28,6 +31,7 @@ func init() {
decryptCmd.Flags().StringVar(&plaintextPath, "plaintext-output", "", "optional filepath to write the plaintext from that will be decrypted.")
decryptCmd.Flags().StringVar(&signerPublicKeyOverride, "signer-quorum-key", "", "optional override for the signer quorum key. This option should be used for testing only. Leave this value empty for production decryptions.")
decryptCmd.Flags().StringVar(&solanaAddress, "solana-address", "", "optional solana address, for use when exporting solana private keys.")
decryptCmd.Flags().BoolVar(&hexOutput, "hex-output", false, "when true, outputs as hex-encoded string (useful for binary data like private keys); when false (default), outputs as UTF-8 text (suitable for mnemonics and text)")

rootCmd.AddCommand(decryptCmd)
}
Expand Down Expand Up @@ -81,7 +85,12 @@ var decryptCmd = &cobra.Command{
OutputError(eris.Errorf("unable to decrypt export bundle: %v", err))
}

plaintext := string(plaintextBytes)
var plaintext string
if hexOutput {
plaintext = hex.EncodeToString(plaintextBytes)
} else {
plaintext = string(plaintextBytes)
}

// apply formatting, if applicable
if solanaAddress != "" {
Expand Down
Loading