Make CallHasher specific to ahash::RandomState#261
Merged
tkaitchuck merged 3 commits intotkaitchuck:masterfrom May 4, 2025
Merged
Make CallHasher specific to ahash::RandomState#261tkaitchuck merged 3 commits intotkaitchuck:masterfrom
tkaitchuck merged 3 commits intotkaitchuck:masterfrom
Conversation
tkaitchuck
approved these changes
Apr 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As pointed out in #242 (comment), the
CallHashertrait used by the specialization feature does not need to work for arbitraryB: BuildHasher.aHash/src/specialize.rs
Lines 20 to 22 in 3a54154
It's enough to work for
ahash::random_state::RandomStateonly. This trait is private to this crate and is only ever used with ahash'sRandomState.aHash/src/specialize.rs
Lines 19 to 21 in 6dfeeae
This simplifies the existing nightly-only specialization and also the stable version in #242 by eliminating some unreachable branches.