Skip to content

Also run resizeText at window.onload #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

nfriedly
Copy link

@nfriedly nfriedly commented Jul 8, 2016

I had a site where occasionally headlines would still be too big. I eventually tracked it down to me running the plugin at DOMReady (e.g.$(function() { /* run stuff here */});) but other page assets such as fonts and CSS downloading later and essentially re-resizing my headlines to be too large.

While just delaying this plugin until onload is feasible, I think this change is the better option.

I also fixed a few typos I spotted ;)

nfriedly added 2 commits July 8, 2016 15:11
"trottle" > "throttle" in code & comments + a couple of other comment typos.
@nfriedly
Copy link
Author

nfriedly commented Jul 8, 2016

Oh, this only has the full-size file. If you want, I can include a minified one also.

With UglifyJs2 (via jscompress.com)
@nfriedly
Copy link
Author

(I decided to go ahead and include the minified version after all since I needed it anyways)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant