refactor: clarify variable naming in "in"/"not in" tests#300
Merged
tkaczmarzyk merged 1 commit intotkaczmarzyk:masterfrom Nov 28, 2025
Merged
refactor: clarify variable naming in "in"/"not in" tests#300tkaczmarzyk merged 1 commit intotkaczmarzyk:masterfrom
tkaczmarzyk merged 1 commit intotkaczmarzyk:masterfrom
Conversation
Owner
|
No problem, I'll cherry-pick it into 3.x branch as well. Thanks! |
tkaczmarzyk
pushed a commit
that referenced
this pull request
Nov 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was a bit sloppy with the variable names in the negated tests added with #292. Should ideally also be applied in the v3 branch, but I wasn't sure how to get there from my fork 🤷
Sorry for the inconvenience :)