This repository was archived by the owner on Dec 19, 2020. It is now read-only.
Prefer more Inclusive language - New gem version#34
Open
andyatkinson wants to merge 7 commits intotjackiw:masterfrom
Open
Prefer more Inclusive language - New gem version#34andyatkinson wants to merge 7 commits intotjackiw:masterfrom
andyatkinson wants to merge 7 commits intotjackiw:masterfrom
Conversation
Prefer blocklist over blacklist Prefer allowlist over whitelist
Fix typo on usage of "Unknown" Fix non whitespace characters Passing tests!
Use jeweler now that it is working to update the gemspec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've replaced whitelist and blacklist with allowlist and blocklist
The test suite is passing for m locally with a couple of newer dependencies and on a more recent version of Ruby
I updated the README to reflect the status although I could back that change out
I updated the gemspec with jeweler.
I'm wondering if a newer version of the gem can be released, 1.1. If you'd like, I'm happy to perform the release, although I'd need to be added to the gem owners:
https://guides.rubygems.org/command-reference/#gem-owner
Thank you for this work back then. We're using this in production. I'm in a position to spend a little time on the maintenance of it as well, but initially we'd just like to make these changes. Cheers!