Clean up code and the repo#1
Conversation
Otherwise, DISSCO cannot be compiled without first running `premake4 clean`. These files don't need to be in the repo anyways. Add a `.gitignore` that prevents these build outputs from being re-committed to the repo.
Instead, re-use `stdout` in the current terminal. We do this because not all machines have `gnome-terminal` installed, nor is it convenient to have to close the spawned instances of `gnome-terminal` each time you synthesize your piece. This is also less prone to breaking; `gnome-terminal` has deprecated the -e flag and that behavior is not standard across terminal emulators.
|
Generally, good changes, but conflicts need cleaning before merge. |
|
Given that I applied If you'd still like my contributions, I'd recommend you cherry-pick them or re-do them. My fork (https://github.com/bepzi/DISSCO-2.0.2) has several branches that might be of interest to you:
My recommendation to you would be:
|
passyur
force-pushed
the
master
branch
2 times, most recently
from
f1d0dbc to
2fb56bc
Compare
2 participants
This pull request:
clang-formatto all the source code, to fix the lack of a consistent code stylegnome-terminal