feat: add SerialOpener hook to FlasherOptions#44
Merged
Conversation
Enables callers to intercept port opens for coordinated multi-consumer access (e.g. a serial monitor running alongside the flasher).
Member
|
cc @georgik |
Member
|
Thank you for the addition here @jgangemi now merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an optional
SerialOpenerhook toFlasherOptionsso callers can intercept how serial ports are opened, enabling coordinated multi-consumer access to a single physical port.Motivation
When a tool multiplexes one serial port between a live monitor and the flasher, having the flasher call
serial.Opendirectly conflicts with the externally-managed port handle. This hook lets the caller supply its own opener — e.g. one that coordinates with a running monitor — used for both the initial open and the reopen-after-USB-reenumeration path.Details
SerialOpener func(name string, mode *serial.Mode) (serial.Port, error)onFlasherOptions.New()andreopenPort()route opens through a smallopts.openPort()helper that usesSerialOpenerwhen set and falls back toserial.Openotherwise.