Skip to content

Fix gps time calculation #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 13, 2025
Merged

Conversation

rhykw
Copy link

@rhykw rhykw commented Aug 11, 2025

fix #784

The Parse() function in the gps package incorrectly calculates dates on or after June 1st, resulting in a timestamp that is one day earlier than the correct date.

@deadprogram
Copy link
Member

Hello @rhykw thanks for working on this. You probably want to base it off of the dev branch as mentioned here:

https://github.com/tinygo-org/drivers/blob/release/CONTRIBUTING.md#how-to-use-our-github-repository

@rhykw rhykw changed the base branch from release to dev August 11, 2025 07:19
@rhykw rhykw marked this pull request as ready for review August 11, 2025 15:24
@rhykw rhykw force-pushed the fix-gps-time-calculation branch from cde8fd6 to d6e9f4b Compare August 11, 2025 15:35
@rhykw
Copy link
Author

rhykw commented Aug 13, 2025

@deadprogram
Hello, thank you for your suggestion.
I've rebased my pull request on the dev branch.

@deadprogram
Copy link
Member

Thank you for the correction @rhykw now squash/merging.

@deadprogram deadprogram merged commit a31ba26 into tinygo-org:dev Aug 13, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[gps] Parse() function calculates incorrect dates from June 1st onward
2 participants