Sugggestion for updating example_scripts#90
Merged
timjmiller merged 1 commit intotimjmiller:labfrom Mar 25, 2026
Merged
Conversation
Owner
|
Thanks very much for this. I will work on it when I am back in the office. |
timjmiller
reviewed
Mar 12, 2026
timjmiller
reviewed
Mar 24, 2026
Owner
There was a problem hiding this comment.
Fixing the functions that create the table rather than omitting M
timjmiller
reviewed
Mar 24, 2026
Owner
There was a problem hiding this comment.
fixed compare_wham_models to allow ASAP model in plots.
timjmiller
reviewed
Mar 24, 2026
Owner
There was a problem hiding this comment.
just needed to call the unexported function wham:::fancy_scientific
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear Dr. Miller,
My name is Rentaro Mitsuyu, a first-year master’s student at the Tokyo University of Marine Science and Technology. I have been studying using your WHAM codebase.
While working through the sample scripts in "inst/example_scripts", I encountered issues that appear to arise from version updates. To support future learners, I made minor fixes to the sample code and verified that all examples now run successfully.
I would be grateful if you could review these changes.