Skip to content

feat: init program metadata#10

Open
bekauz wants to merge 3 commits intobenskey/template-v2from
benskey/program-metadata
Open

feat: init program metadata#10
bekauz wants to merge 3 commits intobenskey/template-v2from
benskey/program-metadata

Conversation

@bekauz
Copy link
Copy Markdown
Contributor

@bekauz bekauz commented Aug 29, 2025

Description

First stab at the notion of shard metadata.

@bekauz bekauz requested review from hxrts and vlopes11 August 29, 2025 17:12
Comment thread common/src/lib.rs

pub mod shard_metadata;

pub const ZK_MINT_CW20_LABEL: &str = "zk_mint_cw20";
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we actually minting a cw20 and not a token factory token?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the existing demo, yes. could migrate it to tf but cw20 was just faster given that the cw20 contract minter is the processor, so no additional libs were required.

@bekauz bekauz marked this pull request as ready for review September 1, 2025 16:16
@bekauz bekauz requested a review from keyleu September 1, 2025 16:16
Comment on lines +44 to +45
/// Valence verification gateway version
pub valence_version: String,
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have a verification gateway after the onchain zk flow refactor. We have a verification router that points towards verifiers/verification switches using routes. But I see that you have that in the Artifacts below, so I'm not sure what this field is for.

pub authorization_labels: [String; MAX_ITEMS],

/// Route used by the verification gateway, e.g.
/// - ethereum/1.0.0/sp1/2.0.0
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: maybe provide the example of the format we are using? e.g. "0001/sp1/5.0.8/groth16"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yeah perfect. also little question here, these versions are the only ones we have for the on-chain zk flow, right? wondering if this contains everything we need and we can just remove valence_version above

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, maybe the registry used? Each authorization has a VK and a registry, as each Circuit can create messages with different registries so we can have multiple functionality in the same circuit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants