Use PG_MODULE_MAGIC_EXT for PG18 #8868
Open
+15
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziomello
force-pushed
the
pg18_use_pg_module_magic_ext
branch
from
6575386 to
85d718b
Compare
fabriziomello
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8868 +/- ##
==========================================
+ Coverage 82.53% 82.57% +0.04%
==========================================
Files 249 249
Lines 48286 48260 -26
Branches 12318 12314 -4
==========================================
- Hits 39855 39853 -2
- Misses 3494 3524 +30
+ Partials 4937 4883 -54 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fabriziomello
force-pushed
the
pg18_use_pg_module_magic_ext
branch
from
85d718b to
6f23268
Compare
fabriziomello
force-pushed
the
pg18_use_pg_module_magic_ext
branch
from
6f23268 to
c5d4e87
Compare
svenklemm
reviewed
Nov 17, 2025
| #if PG18_GE | ||
| #ifdef PG_MODULE_MAGIC_EXT | ||
| #define TS_MODULE_MAGIC \ | ||
| PG_MODULE_MAGIC_EXT(.name = "timescaledb", .version = TIMESCALEDB_VERSION_MOD) |
Member
There was a problem hiding this comment.
we have 3 different modules, should they all use the same name?
Member
There was a problem hiding this comment.
loader version may not match timescaledb version at runtime which is expected feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
postgres/postgres@9324c8c58065