Fix nested async loop #143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add async support and to_sync decorator The commit adds async support to client methods and introduces a to_sync decorator to allow running async code synchronously. Main methods now have both sync and async versions.
knopki
force-pushed
the
fix-nested-async-loop
branch
from
84b427a to
3427039
Compare
Updates GitHub Actions checkout (v3->v4) and setup-python (v4->v5). Upgrades Python from 3.8/3.11 to 3.9/3.13 across all workflows.
knopki
force-pushed
the
fix-nested-async-loop
branch
from
3427039 to
e0e4a2e
Compare
blokhin
approved these changes
Apr 4, 2025
|
Those are quite sensitive changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the asyncio error:
RuntimeError: asyncio.run() cannot be called from a running event loopThis situation occurs when someone does something stupid. For example, runs synchronous code in asynchronous code, which runs asynchronous code from yascheduler through synchronous code.
For example, when a WSGI netius server runs a synchronous flask app that tries to add a task to the yascheduler via a synchronous wrapper.
The point of the fix is to make a neater wrapper that runs asynchronous code in a thread pool. Also, asynchronous methods are made available for use. These are used in cli utils.
Other changes to fix CI: