Skip to content

[Cherry-pick] memtable: Shrink sparse raft-engine memtable entry index buffers more proactively after compaction. (#401)#402

Merged
LykxSassinator merged 1 commit intotikv:tikv-8.5from
LykxSassinator:cp_pr_401
Apr 30, 2026
Merged

[Cherry-pick] memtable: Shrink sparse raft-engine memtable entry index buffers more proactively after compaction. (#401)#402
LykxSassinator merged 1 commit intotikv:tikv-8.5from
LykxSassinator:cp_pr_401

Conversation

@LykxSassinator
Copy link
Copy Markdown
Contributor

@LykxSassinator LykxSassinator commented Apr 30, 2026

@LykxSassinator
memtable: Shrink sparse raft-engine memtable entry index buffers more…
3e153d3 
… proactively after compaction. (tikv#401)

close tikv/tikv#19544

Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@ti-chi-bot ti-chi-bot Bot added the dco-signoff: yes Indicates the PR's author has signed the dco. label Apr 30, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 30, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e63ba4b9-2925-4a61-b738-d043c975dfd0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ti-chi-bot ti-chi-bot Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 30, 2026
@ti-chi-bot ti-chi-bot Bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Apr 30, 2026
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Apr 30, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: glorv, overvenus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 30, 2026
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Apr 30, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-04-30 08:04:00.668741584 +0000 UTC m=+2844245.874101641: ☑️ agreed by glorv.
  • 2026-04-30 08:04:09.596839894 +0000 UTC m=+2844254.802199951: ☑️ agreed by overvenus.

@LykxSassinator
Copy link
Copy Markdown
Contributor Author

LykxSassinator commented Apr 30, 2026

/merge

@LykxSassinator LykxSassinator merged commit 3d84405 into tikv:tikv-8.5 Apr 30, 2026
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@overvenus overvenus overvenus approved these changes

@glorv glorv glorv approved these changes

Assignees

No one assigned

Labels

approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LykxSassinator @overvenus @glorv