Skip to content

Proper .config values with parallel_over = "everything" #1049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 18, 2025

Conversation

topepo
Copy link
Member

@topepo topepo commented Jul 16, 2025

Closes #1045

The issue was: we were creating the .config values inside the tuning loops. When using parallel_over = “resamples", the loop had the entire grid. With parallel_over = “everything", only a subset of grid candidates were available within the loop.

To fix this, we’re going to pre-compute the .config values prior to looping. Since those don’t change, they are added to the static object. Unfortunately, many of the tests for internal functions (that assume static is already made) have to be updated, too, hence the large number of altered files.

@topepo
Copy link
Member Author

topepo commented Jul 16, 2025

Workers are failing to start on macos-latest with

Error: Error: Caught an unexpected error of class FutureError when trying to launch future ('tune-grid-1') on backend of class MultisessionFutureBackend. The reason was: Failed to find a functional cluster worker, after attempting to relaunch the parallel worker 3 times

No idea why since that is what I'm using and it worked previously. Let's ignore it for now and I will restart that again in a bit.

@topepo topepo marked this pull request as ready for review July 16, 2025 14:13
@topepo topepo requested a review from hfrick July 16, 2025 14:13
@topepo
Copy link
Member Author

topepo commented Jul 16, 2025

OK, it looks like air kicked in!

The actual changes are in 7285c13 and 8581914

@topepo topepo changed the base branch from main to melodie-switch July 16, 2025 14:17
@topepo
Copy link
Member Author

topepo commented Jul 16, 2025

topepo changed the base branch from main to melodie-switch

🎶 oops I did it again, I used the wrong target branch 🎶

Copy link
Member

@hfrick hfrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! About those macOS skips: didn't you recently-ish do something about conditioning a skip on the date? I think it'd be good to automatically unskip these tests soon so that we don't forget.

@topepo topepo merged commit 9e6f54c into melodie-switch Jul 18, 2025
1 check passed
@topepo topepo deleted the fix-configs branch July 18, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.config is wrong when parallel_over = "everything"
2 participants