Proper .config values with parallel_over = "everything"
#1049
+194
−125
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1045
The issue was: we were creating the
.config
values inside the tuning loops. When usingparallel_over = “resamples"
, the loop had the entire grid. Withparallel_over = “everything"
, only a subset of grid candidates were available within the loop.To fix this, we’re going to pre-compute the
.config
values prior to looping. Since those don’t change, they are added to thestatic
object. Unfortunately, many of the tests for internal functions (that assumestatic
is already made) have to be updated, too, hence the large number of altered files.