[LOOP-5405] Activity Presets Core #688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Camji55
commented
Aug 21, 2025
Comment on lines
-118
to
+126
| let container = try decoder.container(keyedBy: CodingKeys.self) | ||
| if let symbolTypeValue = try container.decodeIfPresent(SymbolType.self, forKey: .symbolType) { | ||
| self.symbolType = symbolTypeValue | ||
| if let container = try? decoder.container(keyedBy: CodingKeys.self) { | ||
| self.symbolType = try container.decode(SymbolType.self, forKey: .symbolType) | ||
| self.tint = try container.decodeIfPresent(SymbolTint.self, forKey: .tint) | ||
| self.value = try container.decode(String.self, forKey: .value) | ||
| } else { | ||
| let container = try decoder.singleValueContainer() | ||
| self.symbolType = .emoji | ||
| self.tint = nil | ||
| self.value = try container.decode(String.self, forKey: .symbolType) | ||
| self.value = try container.decode(String.self) |
There was a problem hiding this comment.
This change is to support migration from the old preset symbol type to the new one.
Camji55
commented
Aug 21, 2025
Comment on lines
+365
to
+366
| case "legacyWorkout": | ||
| self = .custom |
There was a problem hiding this comment.
If a legacy workout is found when trying to decode, I just have it marked as custom here. I think ideally, this would decode into a .preset(TemporaryPreset), but I'm not sure what settings I'd provide it.
ps2
approved these changes
Aug 22, 2025
Comment on lines
+365
to
+366
| case "legacyWorkout": | ||
| self = .custom |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://tidepool.atlassian.net/browse/LOOP-5405