-
Notifications
You must be signed in to change notification settings - Fork 739
SlotMachineClock: Support for different timezones #3022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
All animations for all slots are in, they all work for all times. Fully functioning app.
Fixed lint issues when attempting to pull
Fixed more lint issues
Lint issues might have been caused with line endings
Previously called time.now() without regard for timezone of the tidbyt user
Next StepsHello! Thank you so much for your change 🤜 🤛 . There are a few things you need to do:
Manual Review RequiredHang tight! A Tidbyt engineer will be by shortly to review your change. Here is what they will be looking for:
|
@Rob-Keys I'm not sure this is going to work. Usually we read the current timezone from the special config timezone = config.get("$tz", "America/New_York") |
@danielsitnik Thank you, I adjusted the line to your suggestion. |
Yes, sadly it has not been documented. :( |
Small change but important, the app now gets the timezone from the config to adjust the time shown.