Allow Starter creation to use the server-default project - #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tdc configureproject discovery and the explicit/profile project precedence unchanged.tidb.cloud/projectlabel and letting TiDB Cloud select the account default.--project-idinvalid and prevent empty project labels from reaching the API.Why
The create resolver treated a missing profile
project_idas a local configuration error even though the Starter API supports requests without a project label. This blocked users who intentionally removed the discovered project ID or used credentials and region settings without a configured profile.The live test also confirms that the server-selected account default can differ from the
tidbx_virtualproject discovered bytdc configure, so these two defaults are documented and tested separately.User impact
Project selection now follows this order:
--project-id;project_id;Validation
make testmake e2emake live-e2e-dbgit diff --checkThe live lifecycle created, queried, updated, and deleted its uniquely named Starter cluster without a configured or explicit project ID. No
tdc-e2e-*cluster remained after the run.