feat: add global preferences and privacy-preserving telemetry - #28
Merged
Conversation
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
~/.tdc/.preferencesfile, with safe migration from the legacy[logging]section in~/.tdc/config.https://tdc-telemetry.tidbcloud.com, show the telemetry notice only from release installers, and allow the deployment workflow to update the server-side public hostname without exposing backend credentials.docs/spec/done/.User impact
Release builds send at most one anonymous completion event for eligible commands. Events contain command and flag names without values, stable result codes, duration, placement, and runtime metadata. Credentials, tokens, SQL, paths, contents, output, raw errors, profile names, and cloud resource IDs are excluded. Help, version, commandless usage, all
tdc updatemodes, development builds, and recognized CI environments do not send telemetry by default.Users can opt out persistently with
[telemetry] enabled = falsein~/.tdc/.preferences, or for one process withTDC_TELEMETRY=off.Validation
make testmake e2e/healthz200,/readyz200, and ingestion 202 attdc-telemetry.tidbcloud.com