[Event Highlighting]: White label minus, dot and colon chars in mini notation #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 10, 2025
thgrund
changed the title
thgrund
changed the title
This was
linked to
issues
Aug 18, 2025
ndr-brt
reviewed
Aug 18, 2025
lib/line-processor.js
Outdated
Comment on lines
9
to
22
| const digitMin = 48; | ||
| const digitMax = 57; | ||
| // A-Z | ||
| const upperCaseMin = 65; | ||
| const upperCaseMax = 90; | ||
| // a-z | ||
| const lowerCaseMin = 97; | ||
| const lowerCaseMax = 122; | ||
| // . | ||
| const dot = 46; | ||
| // - | ||
| const minus = 45; | ||
| // : | ||
| const colon = 58; |
There was a problem hiding this comment.
these const could be kept at the class level, so it will keep the isValidTidalWordChar tidier
There was a problem hiding this comment.
There was a problem hiding this comment.
yes! what a pity that in js there's the need to prepone the class name on every constant call
lib/line-processor.js
Outdated
| static isQuotationMark(character) { | ||
| const code = character.charCodeAt(0); | ||
| // " | ||
| const quotationMark = 34; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix the following issues:
General speaking we need to whitelabel chars that are considered as part of a word inside of the mini notation. I added an additional check, that will avoid that the event highlighting crashes because of a wrong tokenization.