Skip to content

Add Python version GenCrc32 code and unit test cases - #101

Open
YuweiChen1110 wants to merge 1 commit into
masterfrom
77-feature-python-gencrc32-tool-development
Open

YuweiChen1110 wants to merge 1 commit into
masterfrom
77-feature-python-gencrc32-tool-development

Conversation

@YuweiChen1110

Copy link
Copy Markdown
Contributor

Cc: Rebecca Cran rebecca@bsdio.com
Cc: Liming Gao gaoliming@byosoft.com.cn
Cc: Bob Feng bob.c.feng@intel.com
Signed-off-by: Wenzhao Li lwzfight@gmail.com
Signed-off-by: Yuwei Chen yuwei.chen@intel.com

Cc: Rebecca Cran <rebecca@bsdio.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Bob Feng <bob.c.feng@intel.com>
Signed-off-by: Wenzhao Li <lwzfight@gmail.com>
Signed-off-by: Yuwei Chen <yuwei.chen@intel.com>
@YuweiChen1110
YuweiChen1110 requested review from a user, BobCF and lgao4 June 5, 2023 13:51
@YuweiChen1110 YuweiChen1110 linked an issue Jun 5, 2023 that may be closed by this pull request
@codecov

codecov Bot commented Jun 5, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage: 71.31% and project coverage change: +0.10 🎉

Comparison is base (8d9b898) 4.27% compared to head (7c51f64) 4.38%.

❗ Current head 7c51f64 differs from pull request most recent head 5ab9a28. Consider uploading reports for the commit 5ab9a28 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #101      +/-   ##
=========================================
+ Coverage    4.27%   4.38%   +0.10%     
=========================================
  Files         182     184       +2     
  Lines       81605   81734     +129     
=========================================
+ Hits         3490    3582      +92     
- Misses      78115   78152      +37     
Flag Coverage Δ
Linux 4.38% <71.31%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
edk2basetools/GenCrc32/GenCrc32.py 56.52% <56.52%> (ø)
edk2basetools/tests/GenCrc32/test_gencrc32.py 88.33% <88.33%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

## @file
# Calculate Crc32 value and Verify Crc32 value for input data.
#
# Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.<BR>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is new code, it should probably be "Copyright (c) 2024...." since it wasn't written in 2007.

## @file
# Calculate Crc32 value and Verify Crc32 value for input data.
#
# Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.<BR>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same command about the copyright line as above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Python GenCrc32 Tool development

2 participants