GR-10830: Add the Clear style to ThumbprintButton

[alexroussiereTT]

What

We currently don't have a way to display a "clear" button, meaning a button that doesn't have a background color, nor border.
Even though we do have some clear button currently within the Customer app, the way they are implemented is via the local ButtonWithDrawable class using a style that is within the Thumbprint library.
This PR is for adding more support to the ThumbprintButton itself, so we can keep transitioning from the Client app ButtonWithDrawable to the ThumbprintButton

How

• Looked at the Thumbprint.Button.Clear style within button_styles.xml and use it to create a CLEAR ThumbprintButtonType
• Adding a clear buttonType attribute so we can set it via XML

Testing

• You can create a test layout.xml and add a ThumbprintButton with a app:buttonType="clear" and check the preview

Personally I tested it by publishing to my local maven repo and used it directly within the client app. Looked good.

Screenshot

[dzirbel]

Hm, is this part of Thumbprint officially? I don't see it in https://thumbprint.design/components/button/usage/. In the past I think I've just used a clickable TextView for cases like this, which might be more semantically accurate.

[mallikapotter]

Let's check with Erik Goens to see which we want to do -> add it or use a clickable TextView.

…

On Thu, Jan 5, 2023 at 12:31 PM Dominic Zirbel ***@***.***> wrote: Hm, is this part of Thumbprint officially? I don't see it in https://thumbprint.design/components/button/usage/. In the past I think I've just used a clickable TextView for cases like this, which might be more semantically accurate. — Reply to this email directly, view it on GitHub <#56 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACV5ODOEVJ7Z3EZJZZA3XHTWQ4VTNANCNFSM6AAAAAATSCZ2XU> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[alexroussiereTT]

From what I see currently, we are using this:

 <!-- TODO(PUNK-1160) This is not defined in Thumbprint -->
    <style name="Thumbprint.Button.Clear">
        <item name="android:background">?android:attr/selectableItemBackground</item>
        <item name="android:textColor">@color/button_clear_text_color_selector</item>
    </style>

which makes it sound like it just never got added. But it's used 42 times currently in the app.
The iOS code base seems to have what they call a Link button that is a bit similar I guess.

[alexroussiereTT]

I will just add that the benefits of using a Button class are:

• We ensure the 48dp clickable area, which is per accessibility/guideline (A TextView by default is only 24dp)
• When we use an icon, we are having the same space between the text and the icon than any other buttons in the app, out of the box (no need to manually add the padding, and do the search of what the value should be)
• It uses the right colors for the enable/disable states out of the box

[lasya-tack]

Let's check with Erik Goens to see which we want to do -> add it or use a clickable TextView.
…
On Thu, Jan 5, 2023 at 12:31 PM Dominic Zirbel @.> wrote: Hm, is this part of Thumbprint officially? I don't see it in https://thumbprint.design/components/button/usage/. In the past I think I've just used a clickable TextView for cases like this, which might be more semantically accurate. — Reply to this email directly, view it on GitHub <#56 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACV5ODOEVJ7Z3EZJZZA3XHTWQ4VTNANCNFSM6AAAAAATSCZ2XU . You are receiving this because you are subscribed to this thread.Message ID: @.>

Fwiw, iOS has had a "LINK" button style for a very long time.
https://thumbprint.design/components/button/ios/
We also have LINK as a CtaTheme on graphql that is used to style buttons from server. Imo, supporting LINK style on android button makes sense to easily support server driven button styling.