Skip to content

Alignment to original HA popup. #1098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dobby5 wants to merge 2 commits into
base: dev
Choose a base branch
from
+649 −384
Open

Alignment to original HA popup. #1098

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a746fc9
Fixed the bug that left a margin on the left and right sides. (Mobile…
Nov 9, 2025
ea3fdcb
Reflecting change requests
Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions js/plugin/browser-player.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@ import { property } from "lit/decorators.js";

import "./browser-player-editor.ts";

import "./types";

class BrowserPlayer extends LitElement {
@property() hass;
@property({ attribute: "edit-mode", reflect: true }) editMode;
Expand Down
2 changes: 1 addition & 1 deletion js/plugin/dashboard-cards/tile-card.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import { html, LitElement, nothing, PropertyValues } from "lit";
import { until } from 'lit/directives/until.js';
import { property, state } from "lit/decorators.js";
import { LovelaceCard, LovelaceGridOptions } from "../types";
import { BrowserModTileCardEditor } from "./tile-card-editor";
import structuredClone from "@ungap/structured-clone";
import { getLovelaceRoot } from "../../helpers";
import { LovelaceGridOptions, LovelaceCard } from "../../types/types";
Copy link
Collaborator

@dcapslock dcapslock Nov 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to move types.

Copy link
Author

@dobby5 dobby5 Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessary, but it would be nice, because it would mean that the project would at least follow the structural standards to some respects.

Copy link
Collaborator

@dcapslock dcapslock Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tile-card should have no changes now with types not moving.


export class BrowserModTileCard extends LitElement {
@property() hass;
Expand Down
24 changes: 15 additions & 9 deletions js/plugin/popup-card.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import "./popup-card-editor";
import { getLovelaceRoot } from "../helpers";
import { repeat } from "lit/directives/repeat.js";
import { ifDefined } from 'lit/directives/if-defined.js';
import { icon } from "./types";
import { IconProps } from "../types/types";
import { findPopupCardConfigByEntity } from "./popup-card-helpers";

class PopupCard extends LitElement {
Expand Down Expand Up @@ -72,7 +72,7 @@ class PopupCard extends LitElement {
${this._config.icons
? repeat(
this._config.icons,
(icon: icon, index) => html`
(icon: IconProps, index) => html`
<ha-icon-button
.title=${icon.title ?? ""}
class=${ifDefined(icon.class)}
Expand Down Expand Up @@ -256,14 +256,20 @@ window.addEventListener("browser-mod-bootstrap", async (ev: CustomEvent) => {
ev.preventDefault();
let properties = { ...cardConfig }
delete properties.card;
window.browser_mod?.service("popup", {
content: cardConfig.card,
...properties,
});
setTimeout(
() => {
window.browser_mod?.showMoreInfo('', '', false, false, true);
window.browser_mod?.service("popup", {
content: cardConfig.card,
...properties,
});
},
() =>
lovelaceRoot.dispatchEvent(
new CustomEvent("hass-more-info", {
bubbles: true,
composed: true,
cancelable: false,
detail: { entityId: "" },
})
),
10
);
}
Expand Down
Loading