adomik/add_key_value #1

thomasferal · 2021-09-24T07:56:41Z

Type of change

Bugfix
Feature
New bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other

Description of change

test parameters for validating bids

{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

contact email of the adapter’s maintainer
official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

A link to a PR on the docs repo at https://github.com/prebid/prebid.github.io/

Other information

* Validate image size * Support net revenue * Add widget view pixel

… build (prebid#7679) * console log innerWidth * hmmm * more debug * weird * if I change to larger mediaQuery it works I think * stub window.top becasue we are mocking just window * stub similar to sizeConfig test * addressing window things * i camel cased * stub stuff right * remove debug logs

Co-authored-by: Bernhard Pickenbrock <bernhard.pickenbrock@smaato.com>

…ion links (prebid#7672)

- Use the provided storage manager - Capture target demand provider & account id - Add flag to trigger randomly-generated demo bid response

* updated url * update metrics url Co-authored-by: John Mayor <john@Johns-iMac.local>

* Datablocks Tests: fix failing tests * take out source

* Update GetFloors * Update Strings must use singlequote * Update push * Update remove space * Push Test * Push Test 2 * New Attempt * New Attempt 2 * New Attempt 3 * New Attempt 5 Co-authored-by: sgimenez <sergi.gimenez@richaudience.com>

* adpod category support test * Revert "adpod category support test" This reverts commit 70a3cf2. * adpod category support test * Revert "adpod category support test" This reverts commit 70a3cf2. * Adhese bid adapter: make the vastContentAsUrl setting configurable Co-authored-by: Tim Sturtewagen <tim@adhese.com> Co-authored-by: Paweł L <pawel.lankocz@adhese.eu> Co-authored-by: westerschmal <30859973+westerschmal@users.noreply.github.com>

…rebid#7661) * Add Index Exchange Video Adapter * add support for handling vastXML responses in PBJS * Remove Video Adapter code Co-authored-by: Michael Harris <michael.harris@indexexchange.com> Co-authored-by: Arven Ding <arven.ding@indexexchange.com> Co-authored-by: IX Prebid Support <prebid.support@indexexchange.com> Co-authored-by: Michael Burns <mlb7687@users.noreply.github.com> Co-authored-by: shahin.rahbariasl <shahin.rahbariasl@indexexchange.com> Co-authored-by: Kajan Umakanthan <umakajan@umakajan.com>

* Changed net revenue to True * Added groupm as alias in pubmaticBidAdapter * Added gvlid for groupm alias * add space for linting Co-authored-by: Azhar <azhar@L1119.local> Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com>

* set gpid * fix gptPreAuction tests * clean logic + add test

Running npm ci with npm 8.x installs dependencies in plugins/eslint/node_modules, which chokes the linter.

* adding ccpa support for emx_digital adapter * emx_digital ccpa compliance: lint fix * emx 3.0 compliance update * fix outstream renderer issue, update test spec * refactor formatVideoResponse function to use core-js/find * Add support for schain forwarding * Resolved issue with Schain object location * prebid 5.0 floor module and advertiserDomain support * liveramp idl and uid2.0 support for prebid * gpid support * remove utils ext * remove empty line * remove trailing spaces * move gpid test module * move gpid test module * removing trailing spaces from unit test * remove comments from unit test Co-authored-by: Nick Colletti <nick.colletti@emxdigital.com> Co-authored-by: Nick Colletti <gnomish@gmail.com> Co-authored-by: Kiyoshi Hara <Kiyoshi.Hara@emxdigital.com> Co-authored-by: Dan Bogdan <daniel.bogdan@emxdigital.com> Co-authored-by: Jherez Taylor <jherez.taylor@emxdigital.com> Co-authored-by: EMXDigital <emxdigital@emxdigital.com> Co-authored-by: Rakesh Balakrishnan <Rakesh.Balakrishnan@emxdigital.com> Co-authored-by: EMX Digital <43830380+EMXDigital@users.noreply.github.com> Co-authored-by: Kevin <kevin.hagens@brealtime.com>

…d#7706)

* add required clickurl in every native adrequest * allows the native response to be given as is to prebid if possible * add unit tests on new Native case * Handle meta object in bid response with default addomains array * fix icon retrieval in Native case * Update priorities in case of multiple mediatypes given * improve robustness and fix associated unit test on picture urls * add support for params.size parameter * add unit test on new size format * Makes sure the playerSize format is consistent * enable Vast response on bidder adapter * fix lint errors * add test on Vast format case * add userId to bidrequest * revert package-lock.json changes

Co-authored-by: John Salis <john@beachfront.com>

…rebid#7738) Update tests that fail spuriously: prebid#7355 I was not able to reproduce the failures, but in debugging I ruled out the possibility of module loading order and I believe the most likely culprit is other tests asynchronously calling `utils.logInfo` that sometimes happen in-between these tests' setup and assertions. This may not be the real issue, but IMO testing log messages makes little sense anyway, so I updated them to test the actual SOT behavior.

…tm alert (prebid#7737) * Update gumgumBidAdapter.js * Update adagioBidAdapter.js

* SRA support * apply code review feedback SRA * removed redundant config check * Replace not-supported array flat method. Co-authored-by: Carlos Felix <carlos.felix@33across.com>

Fix an issue with the `gdprEnforcement` module. See prebid#7741

* feat: Add handling for a custom client id feat: Send us privacy string * test: Add test case to make sure the expiry is also not touched and update the mocked response Co-authored-by: Mike Marcus <mike@lotame.com>

* ortb2Imp.instl * ortb2Imp.instl unit-test * numeric boolean validations * refacotor for false 0 * tests stable

Co-authored-by: skocheri <skocheri@rubiconproject.com>

* fix: add delay between cookie sync calls * fix(VidoomyBidAdapter): use default triggerPixel * fix: use getUserSyncs hook to sync cookies * fix: handle 204 no response without error log * chore: refactor getUserSyncs * test: update vidoomyBidAdapter tests * fix: remove Macro * fix: query params * fix: gdpr consent * fix: vidoomyBidAdapter tests * fix: use USP_CONSENT in cookie sync urls * fix(vidoomyBidAdapter): sizes format for video mediatype * fix: vast xml * fix: send gdpr as string * chore: add adUnitCode to prebid request

) `pbjs.installedModules` does not work correctly when using prebid as an npm dependency (prebid#7287), because it's generated by a gulp task. This moves generation of `installedModules` to the `pbjsGlobals` babel plugin that we ask npm consumers to use for prebid.

…#7690) This adds 'addTargetingKeys' as a config option that means 'allow all default targeting keys, plus these'. prebid#7249

Co-authored-by: atkachov <atkachov@admixer.ua>

…support to wam2gam and smartadserver (prebid#7728) * update .submodules.json to include weborama rtd update .submodules.json to include weborama rtd submodule * fix jsdoc * add support to wam2gam * fix unit test * fix bad copy paste * save dev * add feature * rename properties * update unit tests * fix doc * fix doc ~ * fix doc 3 * rename bigsea contextual * rename wam2gam * refactor code * rename setGAMTargeting * improve doc, example * update conf * fix doc * fix identation * fix identation 2 * remove empty line into end * remove empty line 2 * fix jsdoc * add support to wam2gam * fix unit test * fix bad copy paste * save dev * add feature * rename properties * update unit tests * fix doc * fix doc ~ * fix doc 3 * rename bigsea contextual * rename wam2gam * refactor code * rename setGAMTargeting * improve doc, example * update conf * fix doc * fix identation * fix identation 2 * remove empty line into end * remove empty line 2 * add intersection RtdProvider and spec (prebid#7710) Co-authored-by: atkachov <atkachov@admixer.ua> Co-authored-by: AdmixerTech <35560933+AdmixerTech@users.noreply.github.com> Co-authored-by: atkachov <atkachov@admixer.ua>

* vastXml as bid.ad * test added * logic with ext.bidtype * fix tests * fix tests(3) * change .md for video support sample Co-authored-by: Surovenko Alexey <surovenko.alexey@gmail.com>

* Add getUserSyncs function * add unit tests * add unit tests Co-authored-by: mifanich <mihail.ivanchenko@nextmillennium.io>

* [BeOp adapter] Fix tracking params * Missing comma

* PBS Bid adapter: timeout user syncs if they never load In some situations the browser never triggers load/error events for user syncs, so the PBS adapter remains stuck (prebid#6354). This adds a timeout for image/iframe syncs. * Clear timeout in utils.waitForElementToLoad

* TargetVideo bid adapter * TargetVideo bid adapter * TargetVideo bid adapter * TargetVideo Bid Adapter update * TargetVideo Bid Adapter implementing requested changes

…bid#7787) * HBT-156: Added Google's additional consent (#1) * HBT-156: Added Google's additional consent * HBT-156: Code refactored Co-authored-by: Faisal Islam <faisal.islam@vivacomsolutions.com> * Update improvedigitalBidAdapter.js Updated version Co-authored-by: Samiul Amin Shanto <93644987+samiul-shanto@users.noreply.github.com> Co-authored-by: Faisal Islam <faisal.islam@vivacomsolutions.com>

jsnellbaker added 7 commits September 23, 2021 14:04

dchain module + appnexus dchain support

3e49f59

code updates and unit tests

d5e660d

update basic dchain object

5c7e239

add proper test description

60f0695

update appnexus dchain node

1b9a38f

fix typo

545662b

clean up comments

3601d6d

thomasferal force-pushed the adomik/add_key_value branch 5 times, most recently from 742751a to 6ccab3b Compare November 4, 2021 11:14

jsnellbaker and others added 18 commits November 5, 2021 09:54

merge branch master + resolve conflicts

48a4533

alter logic on when to add bidder dchain

85b01fd

Engageya bid adapter improvements (prebid#7656)

564dcbe

* Validate image size * Support net revenue * Add widget view pixel

Smaato: Pass through bidRequest.schain (prebid#7675)

539d1b4

Co-authored-by: Bernhard Pickenbrock <bernhard.pickenbrock@smaato.com>

expose seedtag gvl id for TFC2 support (prebid#7674)

6539e76

docs only: remove reference to release notes page and some documentat…

5ad61fc

…ion links (prebid#7672)

Capture target demand provider (prebid#7636)

4253497

- Use the provided storage manager - Capture target demand provider & account id - Add flag to trigger randomly-generated demo bid response

Datablocks Bid Adapter: update url (prebid#7680)

3e343ed

* updated url * update metrics url Co-authored-by: John Mayor <john@Johns-iMac.local>

Datablocks Tests: fix failing tests (prebid#7687)

89f61a7

* Datablocks Tests: fix failing tests * take out source

add bidderDefaultFunction (prebid#7628)

1463ed9

GPT Pre Auction: setting GPID (prebid#7671)

bd6f395

* set gpid * fix gptPreAuction tests * clean logic + add test

Do not lint node_modules (prebid#7689)

8163a23

Running npm ci with npm 8.x installs dependencies in plugins/eslint/node_modules, which chokes the linter.

send all custom params to the bidder (prebid#7685)

4809a4e

kevinhagensjr and others added 28 commits November 18, 2021 12:14

Limelight Digital Bid Adapter: Add optional Publisher ID field (prebi…

24ac6e3

…d#7706)

Merge branch 'appnexus_dchain_start'

3958012

add first-party data support to beachfront adapter (prebid#7733)

29bf57d

Co-authored-by: John Salis <john@beachfront.com>

Prebid 6.2.0 Release

89a6e55

Increment pre version

898f1f6

gumgum & adagio Bid Adapters: remove extra defensive code to solve lg…

a1f3038

…tm alert (prebid#7737) * Update gumgumBidAdapter.js * Update adagioBidAdapter.js

33acrossBidAdapter: Add Support for SRA (prebid#7703)

dd33c8c

* SRA support * apply code review feedback SRA * removed redundant config check * Replace not-supported array flat method. Co-authored-by: Carlos Felix <carlos.felix@33across.com>

Remove redundant alias (prebid#7742)

329deb8

Fix an issue with the `gdprEnforcement` module. See prebid#7741

Lotame panorama id submodule: handle consent (prebid#7644)

2a60735

* feat: Add handling for a custom client id feat: Send us privacy string * test: Add test case to make sure the expiry is also not touched and update the mocked response Co-authored-by: Mike Marcus <mike@lotame.com>

Yahoo SSP Bid Adapter: interstitial fix (prebid#7746)

678b06d

* ortb2Imp.instl * ortb2Imp.instl unit-test * numeric boolean validations * refacotor for false 0 * tests stable

Kinesso fixing the endpoint construction (prebid#7743)

b9953ee

Co-authored-by: skocheri <skocheri@rubiconproject.com>

Add 'targetingControls.addTargetingKeys' configuration option (prebid…

7d5da66

…#7690) This adds 'addTargetingKeys' as a config option that means 'allow all default targeting keys, plus these'. prebid#7249

add alias futureads (prebid#7753)

c8265eb

Co-authored-by: atkachov <atkachov@admixer.ua>

Zeta Ssp Bid Adapter: vast xml for bid (prebid#7740)

820afe7

* vastXml as bid.ad * test added * logic with ext.bidtype * fix tests * fix tests(3) * change .md for video support sample Co-authored-by: Surovenko Alexey <surovenko.alexey@gmail.com>

NextMillennium Bid Adapter: add getUserSyncs function (prebid#7749)

e41bbed

* Add getUserSyncs function * add unit tests * add unit tests Co-authored-by: mifanich <mihail.ivanchenko@nextmillennium.io>

BeOp Bid Adapter: fix tracking params (prebid#7759)

d3cfa64

* [BeOp adapter] Fix tracking params * Missing comma

add one more get param to be forwarded (prebid#7745)

bdb0f83

Update Criteo Fast Bid version (prebid#7767)

960215d

TargetVideo Bid Adapter: add new bid adapter (prebid#7718)

4fd5009

* TargetVideo bid adapter * TargetVideo bid adapter * TargetVideo bid adapter * TargetVideo Bid Adapter update * TargetVideo Bid Adapter implementing requested changes

adomik/add_key_value

65d7b05

adomik/add_key_value/spec

d660e4d

thomasferal force-pushed the adomik/add_key_value branch from 6ccab3b to d660e4d Compare November 30, 2021 08:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

adomik/add_key_value #1

adomik/add_key_value #1

Uh oh!

thomasferal commented Sep 24, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

adomik/add_key_value #1

Are you sure you want to change the base?

adomik/add_key_value #1

Uh oh!

Conversation

thomasferal commented Sep 24, 2021

Type of change

Description of change

Other information

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants