Feature/movement through history #76
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasmello
force-pushed
the
feature/movement-through-history
branch
3 times, most recently
from
642e417 to
c87fdfe
Compare
Open
thomas-mauran
approved these changes
Jul 6, 2024
Owner
thomas-mauran
left a comment
thomas-mauran
left a comment
There was a problem hiding this comment.
Overall looks nice, didn't see any issues with the code, some parts could be rewritten for more readability as you mentionned in a TODO.
Owner
|
If you can rebase to fix the merge conflicts @nicholasmello then I will merge |
Adds the ability to move through history to view the moves that have been played. This is NOT equivalent to an analysis board where you can undo moves or look at other lines. Signed-off-by: Nick Mello <[email protected]>
Signed-off-by: Nicholas Mello <[email protected]>
nicholasmello
force-pushed
the
feature/movement-through-history
branch
from
c87fdfe to
4b1d6f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Movement Through History
Description
Adds the ability to look at previous moves using "P" and "N", if you try to make a move it will bring you back to the actual current position to continue playing.
Fixes #65
How Has This Been Tested?
Tested by playing moves to get to common scenarios where things can go wrong such as en passant and castling. Tests have been updated as well.
Checklist: