Skip to content

fix: Add additional characters to be removed#52

Merged
kevin-david merged 3 commits intothlorenz:masterfrom
thompson-tomo:patch-1
Dec 19, 2025
Merged

fix: Add additional characters to be removed#52
kevin-david merged 3 commits intothlorenz:masterfrom
thompson-tomo:patch-1

Conversation

@thompson-tomo
Copy link
Contributor

@thompson-tomo thompson-tomo commented Dec 13, 2025

Closes #51

Is blocking: thlorenz/doctoc#300

Remove both % & \ from id's as required by github/ Also most latin-1 supplement characters are removed.

@thompson-tomo
Copy link
Contributor Author

thompson-tomo commented Dec 14, 2025

@AndrewSouthpaw / @thlorenz i have attempted to work through doctoc issues and this would help close a number of them see thlorenz/doctoc#300

@thompson-tomo
Copy link
Contributor Author

Maybe @adrianmcli or @kevin-david would be able to take a quick look at this PR?

@kevin-david kevin-david merged commit 499b096 into thlorenz:master Dec 19, 2025
4 checks passed
@thompson-tomo thompson-tomo deleted the patch-1 branch December 19, 2025 01:31
@AndrewSouthpaw
Copy link
Collaborator

Thanks @kevin-david for the review! I'm on vacation for a couple weeks and won't be able to respond to messages for a bit.

AndrewSouthpaw pushed a commit to thlorenz/doctoc that referenced this pull request Feb 10, 2026
This ensures that special characters are being correctly handled and producing the expected results. The examples from the below issues have been added to a markdown file and a test added to compared it to the link generated by  the github website.

Closes: #79
Closes: #92
Closes: #96
Closes: #97
Closes: #122 
Closes: #138
Closes: #165 
Closes: #172 
Closes: #175 
Closes: #182 
Closes: #193
Closes: #223 
Closes: #242 
Closes: #260 

Blocked by: thlorenz/anchor-markdown-header#52 & thlorenz/anchor-markdown-header#53

Note the update for above also 
Closes: #167
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Invalid characters in github id

3 participants