Open
Conversation
Updated Font Awesome to 4.7.0, but: - Commit doesn't include compiled CSS as last compiled commit was made 5 years ago. Since then browserslist include very different set of data, which has a great impact of result. It's not for me to decide to do this task. - There are some not needed files in Font Awesome folder; - font-awesome.css is compiled but not used as global.css uses FA with .icon prefix;
Contributor
|
@cienislaw how hard would it be to update to the free versions 5 or even 6 with shims and local hosting? |
Contributor
Author
|
@therampagerado current v4 implementation in theme is backward compatible with font awesome v3 - it uses v3 'icon-' prefix instead of 'fa-' (introduced in v4), thats why including v4-shims from v6 does nothing. to update to v6 and make it user-friendly for those who will buy PRO version, 'icon-' prefix needs to be dropped. I can prepare such branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated Font Awesome to 4.7.0, but: