Expand Kanon curriculum and ship JHU editorial and plugin updates#44
Draft
stevenjmiklovic wants to merge 23 commits into
Draft
Expand Kanon curriculum and ship JHU editorial and plugin updates#44stevenjmiklovic wants to merge 23 commits into
stevenjmiklovic wants to merge 23 commits into
Conversation
- Add 4 new conceptual lessons (1-4) introducing coding agents, skills, artifact types, and harnesses in plain language (no code) - Renumber existing 16 lessons to 5-20 with updated ToC, Lesson Index, and Next-link chain - Create standalone Self-paced Module on Coding Agents and Skill Creation with abstract, learning outcomes, format, and 6 module lessons - Update knowledge.md to reference new module and reflect 20-lesson tutorial - Add property-based validation tests (11 properties, 29 tests) - Add spec documents (requirements, design, tasks) Co-authored-by: Steven J. Miklovic <smiklov1@jh.edu>
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
…tion or class' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
- Update tutorial.md Lesson 5 with macOS/Linux, Windows PowerShell, package manager (npm, Scoop, WinGet), and WSL install options - Update self-paced-module.md Lesson 4 'Before You Begin' with cross-platform Bun installation instructions - Update self-paced-module.md Prerequisites to mention Windows shells and cross-platform Bun availability - Add changelog fragment for the addition
…oordinator guide - Rewrite self-paced-module with accurate CLI exercises, safe practice content, formal assessments, and an answer key - Add curriculum-guide workflow with learning paths, facilitation notes, accessibility considerations, and production-readiness questions - Streamline tutorial lesson descriptions for clarity - Update knowledge.md steering table and set inclusion to manual
…ute exercise covering semantic-search retrieval, source verification, incremental reindexing, and safe index scope. Designed to follow the MCP and evaluation lessons.
…TATION.cff version, date, abstract, and keywords - Expand CONTRIBUTING.md with current curriculum, harness list, and Souk Compass workflow guidance
… - Add Rule 7: keep CITATION.cff version and date-released in sync - Add Step 3 to cut-release-cut workflow for CITATION.cff update - Update exit criteria to include CITATION.cff verification - Bump artifact version to 0.1.2
Updated the description to include more details about the artifacts and their focus on developer workflows.
Updated description and tags for neon-caravan.
…flow discovery and non-Markdown file support so imported skills retain progressive-disclosure layout and fixture files (CSV, TXT). Adapters receive the preserved relative path. ADR-0045 documents the decision and trade-offs.
…skills from eudaemon-ai/academic-ai-library-workshop: - facilitate-library-ai-workshop (learner coaching, 4-module course) - run-library-ai-workshop-cohort (cohort facilitation) - practice-library-reference-interview (fictional patron practice) - review-ai-research-output (evidence-focused research review) Includes course references, simulated practice data, and a library-ai-workshop collection manifest. Catalog regenerated.
…ery Plugin installs via git clone found 0 skills because dist/ is gitignored and the claude-code adapter only emits CLAUDE.md (not SKILL.md). Add scripts/generate-plugin-skills.ts (bun run build:skills) that renders discoverable SKILL.md files to kanon/skills/, committed alongside the bridge. Plugin.json now points at ./kanon/skills/. ADR-0046 documents the decision and its relationship to ADR-0020.
…y Change type from power to skill and add claude-code to harnesses so the kanon guide ships as a discoverable SKILL.md in the plugin. Update ADR index and CONTRIBUTING with library-ai-workshop guidance.
…xpansion Kanon Tutorial knowledge and improve docs
… reviewing and revising Johns Hopkins communications, separating editorial guidance from official approval, legal, privacy, policy, and accessibility decisions. Includes bundled style, brand-asset, website-audit, scoring, checker, evaluation, and sample references. Updates catalog.json and README artifact counts accordingly.
…low table Resolves merge conflict from jhu-main pull. Adds the jhu-editorial-check entry to the kanon artifact's Available Workflows table and bumps the patch version. Also includes changelog fragment for nested-path preservation in plugin skill generation.
github-actions
Bot
added
docs
dependencies
artifact
adr
collection
tool
adapters
labels
![amazon-q-developer[bot]](https://avatars.githubusercontent.com/in/1220912?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary
This PR expands the Kanon curriculum with Johns Hopkins library AI workshop materials, adds the JHU editorial-check knowledge artifact, and updates plugin packaging with nested reference-tree handling.
Review Scope
Reviewed 182 changed files with focus on:
- Security configurations (.gitleaks.toml)
- Core functionality (generate-plugin-skills.ts, parser.ts, adapters)
- New knowledge artifacts (jhu-editorial-check)
- Python evaluation scripts
Findings
No critical blocking defects identified. The code demonstrates good practices:
- Proper error handling in TypeScript scripts
- Well-structured Python evaluation framework
- Appropriate security configurations for placeholder secrets
- Comprehensive validation schemas
Notes
This is a very large PR (17,584 additions across 182 files), making exhaustive review challenging. The changes appear to be primarily additive (new content and features) rather than modifying critical existing functionality. The test coverage appears adequate with property-based tests and eval frameworks included.
Recommendation
The PR can proceed to merge. Consider breaking up large feature additions into smaller PRs in the future for easier review.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing