Handle jog panel and canvas fit buttons positioning for right rulers - #109
Merged
MarkJB merged 3 commits intoAug 15, 2026
Conversation
…el-account-for-right-edge-rulers
…el-account-for-right-edge-rulers
MarkJB
deleted the
chore/ensure-canvas-fit-controls-and-jog-panel-account-for-right-edge-rulers
branch
August 15, 2026 09:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the layout responsiveness of the jog panel and canvas controls by dynamically adjusting their right-side insets based on the active machine profile's origin and the visibility of the properties panel. This ensures that UI elements do not overlap with the ruler or reserved UI space when the machine origin changes or when the properties panel is toggled.
Dynamic UI layout adjustments:
src/renderer/src/App.tsx). [1] [2] [3] [4]PlotCanvasControls) now accept arightInsetPxprop, allowing their right offset to be adjusted based on the ruler's position, providing consistent spacing and avoiding UI collisions (src/renderer/src/components/PlotCanvas/PlotCanvas.tsx,src/renderer/src/components/PlotCanvas/components/PlotCanvasControls.tsx). [1] [2] [3]Testing improvements:
tests/component/App.test.tsx).Supporting changes:
RULER_WandOriginTypewhere needed to support the new layout calculations (src/renderer/src/App.tsx,src/renderer/src/components/PlotCanvas/PlotCanvas.tsx). [1] [2]