Open
Conversation
thesps
requested changes
Sep 13, 2024
Owner
thesps
left a comment
There was a problem hiding this comment.
Thanks for this feature, it makes sense to have. I’ve left code comments in review. You should also add some tests that touch this functionality in tests/test_save_load.py
Contributor
Author
|
Ok, I have applied all the comments.
|
Owner
|
I think the code changes for the library reloading are now good, but I'd like to see more tests:
|
Owner
|
Did you get a chance to resolve the comments above RE more robust testing? |
Contributor
Author
|
I have replaced the abspath with basename since a simple check on the .so file name is enough (if the entire path is wrong it will throw an error later when it tries to run the inference) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a conifer JSON model is loaded conifer is not able to load also the conifer_bridge.so shared libraries (if they were already produced).
This implies:
This PR tries to fix this behavior by looking for the shared library with the last timestamp present in the metadata. It looks for it in the same folder of the JSON if the is not specified by the user.
It works for both the xilinx and cpp backends.