Skip to content

Classic escapers as loadable (loaded by default) extension #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: v3
Choose a base branch
from
Open

Classic escapers as loadable (loaded by default) extension #314

wants to merge 6 commits into from

Conversation

pine3ree
Copy link
Contributor

  1. Provides a better solution than Make default escape method overridable via extensions #312
  2. Allows developer to use the e and escape helper function names for custom functions with different signatures (classic escape functions can be dropped, but also not loaded by default at all using a new engine constructor flag)
  3. Extends the escape method in a retro-compatible way to allow for more customization

@pine3ree pine3ree mentioned this pull request Jun 13, 2023
Open
@pine3ree
Copy link
Contributor Author

A note/reminder for e418761
Maybe throwing a logic exception would be better if the $template property is not assigned. Template functions are meant to be called inside templates anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pine3ree