Skip to content

Add strikethrough support #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add strikethrough support #257

wants to merge 1 commit into from

Conversation

BentiGorlich
Copy link

Add a StrikethroughConverter which converts

  • <strike>Some Text</strike> -> ~~Some Text~~
  • <del>Some Text</del> -> ~~Some Text~~

@BentiGorlich
Add strikethrough support
2843cc3 
Add a new optional converter `StrikethroughConverter`, mention it in the readme and add tests for it
BentiGorlich
BentiGorlich commented Dec 9, 2024
View reviewed changes
README.md
> [!CAUTION]
> [!CAUTION]
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about this change, but PHPStork wouldn't let me revert this 😅

@BentiGorlich BentiGorlich mentioned this pull request Dec 9, 2024
Merged
@mare96
Copy link

mare96 commented Dec 13, 2024 •
edited
Loading

@BentiGorlich Thank you, but <strike> is deprecated can you use <s> also ?

@melroy89 Do you have any thoughts on when this will be merged?

@BentiGorlich
Copy link
Author

Well it might be deprecated, but that doesn't mean that it isn't used anymore. The issue we received about the parsing problem contained the <strike> tag. I can certainly add the <s> tag :)
Since there is not a review from a maintainer yet I have no clue when this will be merged :)

@melroy89
Copy link

Do you have any thoughts on when this will be merged?

although I approved it. I don't have merge rights on this repo. Better ask @colinodell

@mrdezzods
Copy link

please merge this @colinodell

@NineBitsLTD
Copy link

Incorrect implementation. EmphasisConverter exists for this purpose. Your code loses flexible configuration settings.

@BentiGorlich
Copy link
Author

Incorrect implementation. EmphasisConverter exists for this purpose. Your code loses flexible configuration settings.

How would I solve this? And what settings are lost?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@melroy89 melroy89 melroy89 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@BentiGorlich @mare96 @melroy89 @mrdezzods @NineBitsLTD