Add: job to export in multiple formats#236
Open
Achiket123 wants to merge 16 commits intotheopenlane:mainfrom
Open
Add: job to export in multiple formats#236Achiket123 wants to merge 16 commits intotheopenlane:mainfrom
Achiket123 wants to merge 16 commits intotheopenlane:mainfrom
Conversation
Achiket123
requested review from
LemonAid711,
adelowo and
theopenlane-bender
Member
golanglemonade
left a comment
golanglemonade
left a comment
There was a problem hiding this comment.
@Achiket123 can you update the core/common tag here so we can see if ci passes?
Signed-off-by: Achiket Kumar <126181868+Achiket123@users.noreply.github.com>
Signed-off-by: Achiket Kumar <126181868+Achiket123@users.noreply.github.com>
Signed-off-by: Achiket Kumar <126181868+Achiket123@users.noreply.github.com>
|
Comment on lines
+55
to
+72
| github.com/aws/aws-sdk-go-v2 v1.41.1 // indirect | ||
| github.com/aws/aws-sdk-go-v2/aws/protocol/eventstream v1.7.4 // indirect | ||
| github.com/aws/aws-sdk-go-v2/config v1.32.9 // indirect | ||
| github.com/aws/aws-sdk-go-v2/credentials v1.19.9 // indirect | ||
| github.com/aws/aws-sdk-go-v2/feature/ec2/imds v1.18.17 // indirect | ||
| github.com/aws/aws-sdk-go-v2/internal/configsources v1.4.17 // indirect | ||
| github.com/aws/aws-sdk-go-v2/internal/endpoints/v2 v2.7.17 // indirect | ||
| github.com/aws/aws-sdk-go-v2/internal/ini v1.8.4 // indirect | ||
| github.com/aws/aws-sdk-go-v2/internal/v4a v1.4.17 // indirect | ||
| github.com/aws/aws-sdk-go-v2/service/internal/accept-encoding v1.13.4 // indirect | ||
| github.com/aws/aws-sdk-go-v2/service/internal/checksum v1.9.8 // indirect | ||
| github.com/aws/aws-sdk-go-v2/service/internal/presigned-url v1.13.17 // indirect | ||
| github.com/aws/aws-sdk-go-v2/service/internal/s3shared v1.19.17 // indirect | ||
| github.com/aws/aws-sdk-go-v2/service/s3 v1.96.0 // indirect | ||
| github.com/aws/aws-sdk-go-v2/service/signin v1.0.5 // indirect | ||
| github.com/aws/aws-sdk-go-v2/service/sso v1.30.10 // indirect | ||
| github.com/aws/aws-sdk-go-v2/service/ssooidc v1.35.14 // indirect | ||
| github.com/aws/aws-sdk-go-v2/service/sts v1.41.6 // indirect |
Member
There was a problem hiding this comment.
What is importing these aws sdks?
Contributor
Author
There was a problem hiding this comment.
it was there when i pulled from main and caused merge conflict so i just kept it
Member
There was a problem hiding this comment.
What is pulling these in? This repo doesn't have a direct dep on core, only core/common so that shouldn't pull these in.
Co-authored-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com> Signed-off-by: Achiket Kumar <126181868+Achiket123@users.noreply.github.com>
* Add workers * add periodic worker * add deletion reminder worker * use global email config just like we do for api key + host * Add periodic deletion worker * task config generate * bump go.mod * bump corejobs * bump corejobs * migrate jobs from private repo * fix lint
Signed-off-by: Achiket Kumar <126181868+Achiket123@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @golanglemonade , Please review this, i had tested it with slate.js and it is working with that also.