New design implemented for Announcements page #2279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sazedul-haque
changed the base branch from
4.0.0-dev
to
v4-student-dashboard
b-l-i-n-d
requested changes
Dec 29, 2025
| // Setup delete mutation | ||
| this.deleteMutation = this.query.useMutation(this.deleteAnnouncement, { | ||
| onSuccess: () => { | ||
| window.TutorCore.modal.closeModal('tutor-announcement-delete-modal'); |
Collaborator
There was a problem hiding this comment.
Define a const for the modal ID.
Collaborator
Author
There was a problem hiding this comment.
Can we use these to the php template?
Comment on lines
+531
to
+543
| // Update reactive object props instead of replacing it to maintain bindings | ||
| Object.keys(this.values).forEach((key) => delete this.values[key]); | ||
| Object.assign(this.values, values); | ||
| } else { | ||
| this.values = Object.keys(this.fields).reduce( | ||
| const defaultValues = Object.keys(this.fields).reduce( | ||
| (acc, name) => { | ||
| acc[name] = this.fields[name].defaultValue; | ||
| return acc; | ||
| }, | ||
| {} as Record<string, unknown>, | ||
| ); | ||
| Object.keys(this.values).forEach((key) => delete this.values[key]); | ||
| Object.assign(this.values, defaultValues); |
Collaborator
There was a problem hiding this comment.
Please explain what was the issue
Collaborator
Author
There was a problem hiding this comment.
The reset() Bug (Crucial for Alpine)
In the original code, reset() replaces the entire this.values object. In Alpine.js, this often breaks live bindings. If an input field is bound to values.title, and you replace the values object itself, that input sometimes "loses" its connection to the new object.
Recommendation: Use Object.assign() to update the object's properties instead of replacing the object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.