-
Notifications
You must be signed in to change notification settings - Fork 81
New Instructor Quiz Attempt Page Design #2271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 4.0.0-dev
Are you sure you want to change the base?
Conversation
| @include tutor-breakpoint-down(sm) { | ||
| padding-bottom: $tutor-spacing-16; | ||
| } | ||
| padding-bottom: $tutor-spacing-7; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
already has padding-bottom at line number: 27
| tutor_load_template_from_custom_path( $pagination_template_frontend, $pagination_data ); | ||
| } | ||
| ?> | ||
| $confirm_delete = Button::make()->label( __( "Yes, I'm sure", 'tutor' ) ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have made a delete confirmation modal component. Please use there here after my PR is merged.
| @@ -0,0 +1,23 @@ | |||
| <?php | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need this if delete confirmation modal component is used
| &-header { | ||
| display: grid; | ||
| grid-template-columns: 340px 180px 1.5fr 1fr; | ||
| grid-template-columns: 300px 180px 1.5fr 1fr; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double check with the design.
Overview
This pr introduces a UI design overhaul for Quiz Attempts page for Instructor on frontend dashboard. The page has been made dynamic with PHP components that was created.
Changes
format_quiz_attempts()was added inQuizModelclass, this takes the query result of all the quiz attempts and formats it in an array for rendering the quiz attempt list properly.get_quiz_attempts_nav_data()was added inQuiz_Attempt_Listwhich provides the nav links to be used by theNavphp dynamic UI component .array_slice().Popoverphp dynamic UI component.Modalphp component for confirmation modalSearchFilter,Sortingcomponents for searching and sorting list