WIP: Password + Two Factor Authentication Support #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's currently unused. ...Honestly, 2FA+Email would be pointless, so the idea would be 2FA+Password.
…still unsupported)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to use a PBKDF2 + TOTP to login instead of email-based verification.
Patch is aimed to support SQL support for it; However there's no auth endpoint yet.
Do note this is disabled by default. User is supposed to explicitly allow this after having the email validated.
Of course, if they enable this and then get rid of their email... They will be able to use all TMW services except password or TOTP code recovery.
(TOTP doesn't have to be mandatory, however; Would even be cool if you could just set a password and optionally enable 2FA... Oh well.)
PS. Required by MLAPIv2.
Untested.