Fixes #36341 - Extract Ansible artifacts reader - #118
Open
jakduch wants to merge 1 commit into
Open
Conversation
Separate incremental artifact file discovery and reading from runner event parsing and processing. Assisted-By: Codex 5.6 Sol High
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #36341.
Artifact discovery, ordering, file reads, JSON parsing, event routing, and result publication all lived in
AnsibleRunner. This made the incremental file behavior difficult to test independently and coupled filesystem details to event interpretation.Extract an instance-owned
ArtifactsReaderwith a smallnew_artifactsAPI. It is responsible only for finding the runner artifact directory, ignoring partial files, ordering complete events by counter, reading each file once, and returning path/content values.AnsibleRunnerremains responsible for parsing and interpreting the contents, preserving event IDs, timestamps, logging, and output behavior.Unlike the earlier WIP in #84, the reader has no class-level state and does not replace raw events with objects that lose metadata. Add focused tests for ordering, partial files, incremental reads, and an artifact directory that appears after polling starts.
Testing
AI usage disclosure
Per the community discussion on AI policy, the issue was investigated and the changes, tests, and PR wording were prepared with the assistance of Codex 5.6 Sol High. The resulting changes were reviewed before submitting. The commit also includes an
Assisted-Bytrailer.