Fixes #36210 - Correct per-host Ansible exit status - #116
Open
jakduch wants to merge 1 commit into
Open
Conversation
Allow a successful host event to clear the provisional global error status while preserving actual host failures. Assisted-By: Codex 5.6 Sol High
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #36210.
Ansible 2.12 can emit a global error for a missing module on one host while continuing the playbook on other hosts. The global event provisionally marks every unfinished target with exit status
4, but later successful events did not clear that status. Successful hosts were therefore reported as failed.Allow a subsequent
runner_on_okevent to clear only the provisional global error status. Actual per-host failure (2) and unreachable (1) statuses remain unchanged, and newer Ansible versions that abort the whole playbook emit no later successful host event.Add tests for clearing status
4while preserving a real host failure.Testing
AI usage disclosure
Per the community discussion on AI policy, the issue was investigated and the changes, tests, and PR wording were prepared with the assistance of Codex 5.6 Sol High. The resulting changes were reviewed before submitting. The commit also includes an
Assisted-Bytrailer.