Fixes #38060 - Ignore empty Ansible variable files - #115
Open
jakduch wants to merge 1 commit into
Open
Conversation
Treat empty role defaults files as having no variables while keeping malformed and non-mapping YAML as errors. Assisted-By: Codex 5.6 Sol High
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #38060.
Ansible roles commonly contain an empty
defaults/main.yml. Depending on the Psych version, loading such a file returnsnilorfalse; the variables extractor treated either value as invalid YAML data and raisedReadVariablesException. During role import this caused the same roles to be retried and substantially delayed the import dialog.Treat an empty file as a role with no variables. Malformed YAML and non-empty YAML documents that are not mappings still raise the existing exception.
Add a regression fixture and test for an empty defaults file.
Testing
test/variables_extractor_test.rb: 3 runs, 6 assertions, 0 failures, 0 errorsAI usage disclosure
Per the community discussion on AI policy, the issue was investigated and the changes, tests, and PR wording were prepared with the assistance of Codex 5.6 Sol High. The resulting changes were reviewed before submitting. The commit also includes an
Assisted-Bytrailer.