Fixes #38238 - Mark timed out Ansible jobs as failed - #114
Merged
Conversation
adamruzicka
reviewed
Aug 19, 2026
adamruzicka
left a comment
adamruzicka
left a comment
Contributor
There was a problem hiding this comment.
One scope creep comment inline, otherwise lgtm
adamruzicka
approved these changes
Aug 19, 2026
Contributor
Author
|
Updated, thanks. The timeout message now comes from |
Contributor
|
Could you please rebase? Hopefully that should make the test failures go away |
Assisted-By: Codex 5.6 Sol High
Contributor
Author
|
@adamruzicka Rebased and fixed the hash iteration. The latest workflow is waiting for approval after the force-push; could you please approve it? |
Contributor
|
Thank you @jakduch ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AnsibleRunner#publish_exit_statuspublishes the stored per-host exit statuses. The timeout handler called it before replacing those statuses with failure, so a job killed after exceeding its execution timeout could still report previously successful statuses.Set every inventory host's exit status to
2before publishing the timeout result. A regression test verifies that all hosts are marked failed at publication time.This pull request was assisted by Codex 5.6 Sol High.