Remove unused ca_cert and ca_cert_stripped parameters - #495
Merged
Conversation
evgeni
approved these changes
Mar 4, 2025
Member
Author
|
Why were the acceptance tests cancelled? |
Member
GitHub being GitHub |
Member
|
This can be dropped too -- https://github.com/theforeman/puppet-certs/blob/master/manifests/init.pp#L104C4-L104C20 |
Fixes: 028f93a ("Deploy CA directly from build directory")
ekohl
force-pushed
the
remove-unused-parameters
branch
from
March 4, 2025 16:50
f85d9ef to
328043d
Compare
Member
Author
This is a scheduled Ubuntu 20.04 brownout. Ubuntu 20.04 LTS runner will be removed on 2025-04-01. For more details, see actions/runner-images#11101 |
Member
|
oooh, because we're using gha-puppet@v2, not v3? |
Member
Author
Member
Author
|
Looks like puppet-foreman_proxy_certs requires it: theforeman/puppet-foreman_proxy_content#514 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: 028f93a ("Deploy CA directly from build directory")